Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update testing #224

Merged
merged 13 commits into from
Mar 17, 2024
Merged

update testing #224

merged 13 commits into from
Mar 17, 2024

Conversation

knaaptime
Copy link
Member

@knaaptime knaaptime commented Mar 6, 2024 •
edited
Loading

use latest pysal conventions

@codecov Codecov
Copy link

codecov bot commented Mar 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.88%. Comparing base (f431b1d) to head (ed36577).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #224   +/-   ##
=======================================
  Coverage   81.88%   81.88%           
=======================================
  Files          66       66           
  Lines        2291     2291           
=======================================
  Hits         1876     1876           
  Misses        415      415

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jGaboardi
Copy link
Member

Got it working with single core on CI. Now trying again with multi-core.

@jGaboardi
Copy link
Member

Seems to be a quilt cache error when running CI via multicore.

==================================== ERRORS ====================================
________ ERROR collecting segregation/tests/test_multiscalar_profile.py ________
segregation/tests/test_multiscalar_profile.py:10: in <module>
    p = quilt3.Package.browse('osm/metro_networks_8k', "s3://spatial-ucr/")
../../../micromamba/envs/test/lib/python3.12/site-packages/quilt3/telemetry.py:135: in decorated
    results = func(*args, **kwargs)
../../../micromamba/envs/test/lib/python3.12/site-packages/quilt3/packages.py:584: in browse
    return cls._browse(name=name, registry=registry, top_hash=top_hash)
../../../micromamba/envs/test/lib/python3.12/site-packages/quilt3/packages.py:611: in _browse
    tmp_path.rename(local_pkg_manifest)
../../../micromamba/envs/test/lib/python3.12/pathlib.py:1363: in rename
    os.rename(self, target)
E   FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/.cache/Quilt/v0/manifest/3f08088ceabbc6e8d5f8ad1699b254bab0c0ca3808e4893a43ec478ac1fb6ebf.tmp' -> '/home/runner/.cache/Quilt/v0/manifest/3f08088ceabbc6e8d5f8ad1699b254bab0c0ca3808e4893a43ec478ac1fb6ebf'
------------------------------- Captured stderr --------------------------------

Downloading manifest:   0%|          | 0.00/107k [00:00<?, ?B/s]
Downloading manifest: 100%|██████████| 107k/107k [00:00<00:00, 355kB/s]
Downloading manifest: 100%|██████████| 107k/107k [00:00<00:00, 354kB/s]
________ ERROR collecting segregation/tests/test_multiscalar_profile.py ________
segregation/tests/test_multiscalar_profile.py:10: in <module>
    p = quilt3.Package.browse('osm/metro_networks_8k', "s3://spatial-ucr/")
../../../micromamba/envs/test/lib/python3.12/site-packages/quilt3/telemetry.py:135: in decorated
    results = func(*args, **kwargs)
../../../micromamba/envs/test/lib/python3.12/site-packages/quilt3/packages.py:584: in browse
    return cls._browse(name=name, registry=registry, top_hash=top_hash)
../../../micromamba/envs/test/lib/python3.12/site-packages/quilt3/packages.py:620: in _browse
    pkg = cls._from_path(local_pkg_manifest)
../../../micromamba/envs/test/lib/python3.12/site-packages/quilt3/packages.py:628: in _from_path
    pkg = cls._load(open_file)
../../../micromamba/envs/test/lib/python3.12/site-packages/quilt3/packages.py:793: in _load
    meta = reader.read()
../../../micromamba/envs/test/lib/python3.12/site-packages/jsonlines/jsonlines.py:147: in read
    six.raise_from(EOFError, None)
<string>:3: in raise_from
    ???
E   EOFError

@jGaboardi
Copy link
Member

xref #225

@knaaptime
Copy link
Member Author

the way i skirted that multicore thing recently is to group tests that read from that file so they run on the same worker

@knaaptime
Copy link
Member Author

knaaptime commented Mar 17, 2024 •
edited by jGaboardi
Loading

does this supercede 225?

@jGaboardi
Copy link
Member

Did not mean to edit your comment @knaaptime. I think my brain is still off...

@jGaboardi
Copy link
Member

does this supercede 225?

Yes.

the way i skirted that multicore thing recently is to group tests that read from that file so they run on the same worker

Woah! Never seen this before. Let's try to implement here in a subsequent PR.

@jGaboardi jGaboardi mentioned this pull request Mar 17, 2024
Open
@knaaptime knaaptime merged commit 9f5714c into pysal:main Mar 17, 2024
8 checks passed
@knaaptime knaaptime deleted the testing branch March 17, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@knaaptime knaaptime

Labels
CI/testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knaaptime @jGaboardi